-
Notifications
You must be signed in to change notification settings - Fork 293
Android App Bundle Support Added #121
Android App Bundle Support Added #121
Conversation
667b911
to
45a8233
Compare
Checks are failing since in the test environment, there is no |
Hi @mirsamantajbakhsh, this looks very interesting! Bundle support has been a long desired feature and now you implemented it, so thank you! Here are my thoughts:
|
Dear @ClaudiuGeorgiu, About write access, I have checked "Allow edits by maintainers". Furthermore, I added you as collaborator to my branch of Obfuscapk. I'm very proud to take a small part in your amazing project. 🙏 |
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
- Coverage 77.57% 74.81% -2.77%
==========================================
Files 49 50 +1
Lines 2453 2589 +136
Branches 486 559 +73
==========================================
+ Hits 1903 1937 +34
- Misses 422 508 +86
- Partials 128 144 +16
Continue to review full report at Codecov.
|
I made a few changes and merged your PR, thank you very much @mirsamantajbakhsh, I'm glad you found this project interesting and decided to contribute! |
Dear Claudiu,
First of all I wanted to thank you for creating Obfuscapk. I saw some issues in your repository about working with Android Bundle, beside APK files. Therefore, I've added AAB support to obfuscapk using other repository named BundleDecompiler. I have tested and the results were OK.
Please help me if there are other works I should have done.
Best Regards,
Dr. Tajbakhsh